chore: Rename executiondate to occurreddate in DB [TECH-1615] #15648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricocolasante
commented
Nov 10, 2023
...-analytics/src/main/java/org/hisp/dhis/analytics/common/params/dimension/DimensionParam.java
Outdated
Show resolved
Hide resolved
…hisp/dhis/analytics/common/params/dimension/DimensionParam.java
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #15648 +/- ##
============================================
- Coverage 66.21% 66.21% -0.01%
+ Complexity 31267 31265 -2
============================================
Files 3487 3487
Lines 129904 129904
Branches 15170 15170
============================================
- Hits 86013 86010 -3
- Misses 36812 36813 +1
- Partials 7079 7081 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
enricocolasante
requested review from
gnespolino,
lucaCambi77 and
maikelarabori
gnespolino
approved these changes
Nov 13, 2023
lucaCambi77
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #15642
This PR aims to replace all occurrences of executionDate in the DB and repository layer to occurredDate.
The general rule that we are using is that date fields are suffixed with At in the API and then suffixed with Date in the service and the DB layer.